git.cmake: let the environment override BUILD_VERSION #14594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to remove noise when comparing binaries across git commits and more generally for anyone who wants to manual control/override the version number when building with or without a .git/ subdirectory. Signed-off-by: Marc Herbert <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #14594 +/- ##
=======================================
Coverage 51.96% 51.96%
=======================================
Files 309 309
Lines 45576 45576
Branches 10554 10554
=======================================
Hits 23683 23683
Misses 17083 17083
Partials 4810 4810Continue to review full report at Codecov.
|
SebastianBoe
approved these changes
Mar 18, 2019
jukkar
approved these changes
Mar 18, 2019
marc-hb
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to remove noise when comparing binaries across git
commits and more generally for anyone who wants to manual
control/override the version number when building with or without a
.git/ subdirectory.
Signed-off-by: Marc Herbert [email protected]